Skip to content

OCPBUGS-55083: Updates GCP CredentialsRequest #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

OCPBUGS-55083: Updates GCP CredentialsRequest #1353

merged 1 commit into from
Apr 24, 2025

Conversation

theobarberbany
Copy link
Contributor

@theobarberbany theobarberbany commented Apr 16, 2025 •
edited
Loading

  • Adds compute.images.useReadOnly, which is required for provisioning additional disks.

@theobarberbany
Updates GCP CredentialsRequest
f2a0f0b 
- Adds compute.images.useReadOnly
@openshift-ci openshift-ci bot requested review from elmiko and sub-mod April 16, 2025 09:32
@nrb
Copy link
Contributor

nrb commented Apr 22, 2025

/retitle OCPBUGS-55083: Updates GCP CredentialsRequest

@openshift-ci openshift-ci bot changed the title Updates GCP CredentialsRequest OCPBUGS-55083: Updates GCP CredentialsRequest Apr 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 22, 2025
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: This pull request references Jira Issue OCPBUGS-55083, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • Adds compute.images.useReadOnly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Contributor Author

/retest

@theobarberbany
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 22, 2025
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: This pull request references Jira Issue OCPBUGS-55083, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from miyadav April 22, 2025 16:40
@theobarberbany
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2025 •
edited
Loading

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upgrade f2a0f0b link false /test e2e-vsphere-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 f2a0f0b link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-upgrade f2a0f0b link false /test e2e-metal-ipi-upgrade
ci/prow/e2e-openstack f2a0f0b link false /test e2e-openstack
ci/prow/e2e-metal-ipi f2a0f0b link false /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-virtualmedia f2a0f0b link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-ovn-dualstack f2a0f0b link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nrb
Copy link
Contributor

nrb commented Apr 24, 2025

The e2es on GCP passed, and this is a platform specific change.

CI (particularly AWS) is still recovering from quota issues, so I'm going to override the tests on non-GCP platforms.

/override ci/prow/e2e-aws-ovn ci/prow/e2e-aws-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@nrb: Overrode contexts on behalf of nrb: ci/prow/e2e-aws-operator, ci/prow/e2e-aws-ovn

In response to this:

The e2es on GCP passed, and this is a platform specific change.

CI (particularly AWS) is still recovering from quota issues, so I'm going to override the tests on non-GCP platforms.

/override ci/prow/e2e-aws-ovn ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nrb
Copy link
Contributor

nrb commented Apr 24, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
@nrb
Copy link
Contributor

nrb commented Apr 24, 2025

/override ci/prow/aws/e2e-aws-ovn-upgrade

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2025

@nrb: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/aws/e2e-aws-ovn-upgrade

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws-operator
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-upgrade
  • ci/prow/e2e-azure-operator
  • ci/prow/e2e-azure-ovn
  • ci/prow/e2e-gcp-operator
  • ci/prow/e2e-gcp-ovn
  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-metal-ipi-ovn-dualstack
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-metal-ipi-upgrade
  • ci/prow/e2e-metal-ipi-virtualmedia
  • ci/prow/e2e-nutanix
  • ci/prow/e2e-openstack
  • ci/prow/e2e-vsphere-operator
  • ci/prow/e2e-vsphere-ovn
  • ci/prow/e2e-vsphere-ovn-multi-vcenter
  • ci/prow/e2e-vsphere-ovn-serial
  • ci/prow/e2e-vsphere-ovn-upgrade
  • ci/prow/e2e-vsphere-static-ovn
  • ci/prow/goimports
  • ci/prow/golint
  • ci/prow/govet
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/okd-scos-images
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify-crds-sync
  • pull-ci-openshift-machine-api-operator-main-e2e-aws-operator
  • pull-ci-openshift-machine-api-operator-main-e2e-aws-ovn
  • pull-ci-openshift-machine-api-operator-main-e2e-aws-ovn-upgrade
  • pull-ci-openshift-machine-api-operator-main-e2e-azure-operator
  • pull-ci-openshift-machine-api-operator-main-e2e-azure-ovn
  • pull-ci-openshift-machine-api-operator-main-e2e-gcp-operator
  • pull-ci-openshift-machine-api-operator-main-e2e-gcp-ovn
  • pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi
  • pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-upgrade
  • pull-ci-openshift-machine-api-operator-main-e2e-metal-ipi-virtualmedia
  • pull-ci-openshift-machine-api-operator-main-e2e-nutanix
  • pull-ci-openshift-machine-api-operator-main-e2e-openstack
  • pull-ci-openshift-machine-api-operator-main-e2e-vsphere-operator
  • pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn
  • pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn-multi-vcenter
  • pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn-serial
  • pull-ci-openshift-machine-api-operator-main-e2e-vsphere-ovn-upgrade
  • pull-ci-openshift-machine-api-operator-main-e2e-vsphere-static-ovn
  • pull-ci-openshift-machine-api-operator-main-goimports
  • pull-ci-openshift-machine-api-operator-main-golint
  • pull-ci-openshift-machine-api-operator-main-govet
  • pull-ci-openshift-machine-api-operator-main-images
  • pull-ci-openshift-machine-api-operator-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-machine-api-operator-main-okd-scos-images
  • pull-ci-openshift-machine-api-operator-main-security
  • pull-ci-openshift-machine-api-operator-main-unit
  • pull-ci-openshift-machine-api-operator-main-verify-crds-sync
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/aws/e2e-aws-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a82d5db into openshift:main Apr 24, 2025
23 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@theobarberbany: Jira Issue OCPBUGS-55083: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55083 has been moved to the MODIFIED state.

In response to this:

  • Adds compute.images.useReadOnly, which is required for provisioning additional disks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.20.0-202504250541.p0.ga82d5db.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-04-29-095709

@theobarberbany
Copy link
Contributor Author

/cherry-pick release-4.15, release-4.16, release-4.17, release-4.18

@openshift-cherrypick-robot
Copy link

@theobarberbany: cannot checkout release-4.15,: error checking out "release-4.15,": exit status 1 error: pathspec 'release-4.15,' did not match any file(s) known to git

In response to this:

/cherry-pick release-4.15, release-4.16, release-4.17, release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@theobarberbany
Copy link
Contributor Author

/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15

@openshift-cherrypick-robot
Copy link

@theobarberbany: new pull request created: #1376

In response to this:

/cherry-pick release-4.18 release-4.17 release-4.16 release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@sub-mod sub-mod Awaiting requested review from sub-mod

@miyadav miyadav Awaiting requested review from miyadav

Assignees

@nrb nrb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theobarberbany @nrb @openshift-ci-robot @openshift-bot @openshift-merge-robot @openshift-cherrypick-robot